Onboard Intake(2/3): introduce Intake #1124
Conversation
devanshcache
changed the title
|
@devanshcache please note: All of this also applies to #1126 |
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
rubenhoenle
force-pushed
the
onboarding-intake-component
branch
from
36d80c8 to
5664361
Compare
rubenhoenle
left a comment
rubenhoenle
left a comment
There was a problem hiding this comment.
Lot work needs to be done here.
| projectLabel = model.ProjectId | ||
| } | ||
|
|
||
| if !model.AssumeYes { |
There was a problem hiding this comment.
| if !model.AssumeYes { | |
shouldn't be needed anymore after integrating #1217
| return err | ||
| } | ||
|
|
||
| if !model.AssumeYes { |
There was a problem hiding this comment.
| if !model.AssumeYes { | |
shouldn't be needed anymore after integrating #1217
| Example: examples.Build( | ||
| examples.NewExample( | ||
| `Create a new Intake with required parameters`, | ||
| `$ stackit beta intake create --display-name my-intake --runner-id xxx --catalog-uri "http://dremio.example.com" --catalog-warehouse "my-warehouse"`), |
There was a problem hiding this comment.
well, if your subcommand is stackit beta intake create, where does the "instance" in the filepath come from...?
internal/cmd/beta/intake/instance/create/create.go
There was a problem hiding this comment.
Also applies to all the other new subcommands btw
There was a problem hiding this comment.
We would like to keep it this naming if possible $ stackit beta intake if needed moving out of instance folder. Unless that is a hard no-go from you or we are the "ugly duck".
| "fmt" | ||
|
|
||
| "github.com/spf13/cobra" | ||
| "github.com/stackitcloud/stackit-cli/internal/cmd/params" |
docs/stackit_beta_intake_create.md
Outdated
|
|
||
| ``` | ||
| Create a new Intake with required parameters | ||
| $ stackit beta intake create --display-name my-intake --runner-id xxx --catalog-uri "http://dremio.example.com" --catalog-warehouse "my-warehouse" |
There was a problem hiding this comment.
Executing this example gives me an error
There was a problem hiding this comment.
Since I'm also having also no luck with the second full example - could you maybe provide me with some testing instructions for this PR? 😅
There was a problem hiding this comment.
The first one is because we created this PR long time ago (before was opened here) and now that paramter is required. Resolved.
The second one is because when catalog-auth-type is Dremio it actually requires the personalAccessToken to be set, otherwise it can't authenticate with the catalog. I will check if maybe we can make this more intuitive for a user.
The third is because the url you provided does not exist at all (I think), notice also that you don't have any valid token. So even if the URL was correct, the CLI would complain with a message regarding the token. (I believe we can't change this at all...)
docs/stackit_beta_intake_create.md
Outdated
| $ stackit beta intake create --display-name my-intake --runner-id xxx --description "Production intake" --labels "env=prod,team=billing" --catalog-uri "http://dremio.example.com" --catalog-warehouse "my-warehouse" --catalog-auth-type "dremio" --dremio-token-endpoint "https://auth.dremio.cloud/oauth/token" --dremio-pat "MY_TOKEN" | ||
|
|
||
| Create a new Intake with manual partitioning by a date field | ||
| $ stackit beta intake create --display-name my-partitioned-intake --runner-id xxx --catalog-uri "http://dremio.example.com" --catalog-warehouse "my-warehouse" --catalog-partitioning "manual" --catalog-partition-by "day(__intake_ts)" |
There was a problem hiding this comment.
And also the third example fails, I'm giving up with this one for today
There was a problem hiding this comment.
Same the first case from previous comment, catalog-auth-type now is mandatory. Resolved.
yago-123
force-pushed
the
onboarding-intake-component
branch
2 times, most recently
from
5664361 to
5e372ff
Compare
Co-authored-by: Ruben Hönle <git@hoenle.xyz>
yago-123
force-pushed
the
onboarding-intake-component
branch
from
5eba014 to
fffc3db
Compare
4 participants
Description
Intake is composed of three components:
Intake runner has already been merged reference (#952) this PR is continuation of the one of two components of Intake (ticket)
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)